-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thoroughly Shutdown The Stack On Non-Interactive Chip Command #38046
base: master
Are you sure you want to change the base?
Conversation
When there is a non-interactive CHIP Command, be sure to completely shutdown the stack. In the case where the stack is not completely shutdown, it is impossible to run another CHIP Command from within the same address space.
Thank you (again) for all the work that you are putting into making this SDK so complete. I think that I found an issue where the partial shutdown of the stack can cause a problem and hope that this fix is appropriate. If it is, I am more than happy to add testing. I just didn't want to spam you with additional changes unless this fix is on the right track. |
PR #38046: Size comparison from b2a86bd to 01a8990 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding "request for changes" until the testing section in the summary moves from "WIP".
Ideally we would have some description of what fails before the PR and succeeds after. This can serve both as a description of the issue and the test that proves that the issue was fixed. |
Of course! The "problem" is re-running any command implemented as a derive class from I will investigate a way to write a unit test to demonstrate this odd behavior. If, however, you have any suggestions or guidance (as an expert!) I would very much appreciate it! Again, thank you for all the work that you are doing on Matter and the SDK! |
When there is a non-interactive CHIP Command, be sure to completely shutdown the stack. In the case where the stack is not completely shutdown, it is impossible to run another CHIP Command from within the same address space.
Testing
WIP